cosmetics

OpenSim/Region/CoreModules/Avatar/InstantMessage/HGMessageTransferModule.cs

@@ -101,9 +101,6 @@ namespace OpenSim.Region.CoreModules.Avatar.InstantMessage
 
         public virtual void PostInitialise()
         {
-            if (!m_Enabled)
-                return;
-
         }
 
         public virtual void RegionLoaded(Scene scene)

OpenSim/Region/CoreModules/World/Estate/EstateManagementModule.cs

@@ -555,6 +555,8 @@ namespace OpenSim.Region.CoreModules.World.Estate
                 case 3:
                     Scene.RegionInfo.RegionSettings.TerrainTexture4 = texture;
                     break;
+                default:
+                    return;
             }
 
             Scene.RegionInfo.RegionSettings.Save();
@@ -582,6 +584,8 @@ namespace OpenSim.Region.CoreModules.World.Estate
                     Scene.RegionInfo.RegionSettings.Elevation1NE = lowValue;
                     Scene.RegionInfo.RegionSettings.Elevation2NE = highValue;
                     break;
+                default:
+                    return;
             }
 
             Scene.RegionInfo.RegionSettings.Save();

OpenSim/Services/HypergridService/HGInstantMessageService.cs

@@ -89,7 +89,7 @@ namespace OpenSim.Services.HypergridService
                 if (string.IsNullOrEmpty(userAgentService))
                     m_log.WarnFormat("[HG IM SERVICE]: UserAgentService not set in [HGInstantMessageService]");
 
-                object[] args = new object[] { config };
+                object[] args = [ config ];
                 try
                 {
                     m_GridService = ServerUtils.LoadPlugin<IGridService>(gridService, args);

OpenSim/Services/Interfaces/IPresenceService.cs

@@ -43,19 +43,19 @@ namespace OpenSim.Services.Interfaces
 
         public PresenceInfo(Dictionary<string, object> kvp)
         {
-            if (kvp.ContainsKey("UserID"))
-                UserID = kvp["UserID"].ToString();
-            if (kvp.ContainsKey("RegionID"))
-                UUID.TryParse(kvp["RegionID"].ToString(), out RegionID);
+            if (kvp.TryGetValue("UserID", out object ouid))
+                UserID = ouid.ToString();
+            if (kvp.TryGetValue("RegionID", out object orid))
+                _ = UUID.TryParse(orid.ToString(), out RegionID);
         }
 
         public Dictionary<string, object> ToKeyValuePairs()
         {
-            Dictionary<string, object> result = new Dictionary<string, object>();
-            result["UserID"] = UserID;
-            result["RegionID"] = RegionID.ToString();
-
-            return result;
+            return new Dictionary<string, object>
+            {
+                ["UserID"] = UserID,
+                ["RegionID"] = RegionID.ToString()
+            };
         }
     }